Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream libcontainer package #5437

Merged
merged 4 commits into from
Apr 19, 2019
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Mar 19, 2019

Use the upstream libcontainer package, by ensuring that executor pkg binary always has the nsenter code.

By having libcontainer_nsenter_linux.go file be part of the package, any binary containing the package (including tests) would be configured to run libcontainer packages properly.

This doesn't change the behavior of external drivers, as they would still launch executors through plugins that invoke nomad binary to spin up the executor plugin.

@notnoop
Copy link
Contributor Author

notnoop commented Mar 19, 2019

I made this approach as well as #5438. I prefer this one more, considering that it's more consistent with libcontainer documented use case and doesn't require maintaining any additional code beyond needed to set up container.

Copy link
Member

@nickethier nickethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only downside to this is that if a third party driver wants to use the executor they end up duplicating alot having to package their own executor, though that may actually be preferred rather than having Nomad's executor version changed out underneath you.

I agree I think this is the better way forward. Great work!

@notnoop notnoop force-pushed the r-upstream-libcontainer-plain branch from 5b6404f to 6747195 Compare April 19, 2019 13:49
@notnoop notnoop merged commit 54e1e07 into master Apr 19, 2019
@notnoop notnoop deleted the r-upstream-libcontainer-plain branch April 19, 2019 14:15
@notnoop
Copy link
Contributor Author

notnoop commented May 29, 2019

FWIW, this picked up a fix to reduce memory usage required by libcontainer in opencontainers/runc#1984 - so driver/exec no longer need large memory requirement (~70-100MB) for small processes.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants